BUG: lib.infer_dtype with mixed-freq Periods #41526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
May 17, 2021
| @@ -2343,14 +2367,6 @@ def maybe_convert_objects(ndarray[object] objects, bint try_float=False, | |||
| elif util.is_float_object(val): | |||
| floats[i] = complexes[i] = val | |||
| seen.float_ = True | |||
| elif util.is_datetime64_object(val): | |||
There was a problem hiding this comment.
unrelated to the rest of the PR, this chunk of code is just redundant with a chunk below
jreback
added
Period
jreback
requested changes
May 17, 2021
| cdef class PeriodValidator(TemporalValidator): | ||
| cdef inline bint is_value_typed(self, object value) except -1: | ||
| return is_period_object(value) | ||
| cdef bint is_period_array(ndarray[object] values): |
There was a problem hiding this comment.
can you not keep the current PeriodValidator format itself? (e.g. just put this function in validate). this is breaking the pattern.
There was a problem hiding this comment.
this is the same pattern we use for is_datetime_with_singletz_array (and will end up using for is_interval_array in an upcoming PR)
|
kk can you add a note. |
|
whatsnew added + green |
jreback
approved these changes
May 18, 2021
|
thanks |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a convert_period option to lib.maybe_infer_objects